[PATCH] D76896: Color dependent names based on their heuristic target if they have one

2020-04-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Great! Needs some tests though :-) Comment at: clang-tools-extra/clangd/FindTarget.cpp:651 +void +VisitCXXDependentScopeMemberExpr(const CXXDependentScopeMemberExpr *E) { + Refs.push_back( Can you move these into some log

[PATCH] D76896: Color dependent names based on their heuristic target if they have one

2020-04-07 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added reviewers: sammccall, kadircet, hokein. nridge added a comment. Adding some reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 ___ cfe-comm

[PATCH] D76896: Color dependent names based on their heuristic target if they have one

2020-03-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/297 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76896 Files: clang-too