[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

arsenm closed this revision. arsenm added a comment. 175e42303bb2a4253c6512b1ae05b32b0004 , rebased to avoid dependence on ROCM toolchain patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76887/new/ https://rev

[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76887/new/ https://reviews.llvm.org/D76887 ___ cfe-commits mailing list cfe-

[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:271 const ToolChain &HostTC, const ArgList &Args) -: ToolChain(D, Triple, Args), HostTC(HostTC) { +: ROCMToolChain(D, Triple, Args), HostTC(HostTC) { // Lookup b

[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

arsenm created this revision. arsenm added reviewers: yaxunl, gregrodgers. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. arsenm added parent revisions: D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs, D76862: HIP: Ensure new denormal mode attributes are set. This