[PATCH] D76605: [analyzer] Display the checker name in the text output

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2b6ece1fd4e: [analyzer] Display the checker name in the text output (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76605/new/ https

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus added a comment. In D76605#1969535 , @martong wrote: > I was just wondering if it would make sense to have a test with > `display-checker-name=true`. Other than that, LGTM! Could do! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D76605: [analyzer] Display the checker name in the text output

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. I was just wondering if it would make sense to have a test with `display-checker-name=true`. Other than that, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76605/new/ https:/

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:112 reportPiece(NoteID, Piece->getLocation().asLocation(), -Piece->getString(), Piece->getRanges(), Piece->getFixits()); +Piece->getStr

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus updated this revision to Diff 255668. Szelethus marked 8 inline comments as done. Szelethus added a comment. Fixing according to the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76605/new/ https://reviews.llvm.org/D76605 Files: clang/include/clang/StaticAnalyzer/C

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "display-checker-name", +"Display the checker name

[PATCH] D76605: [analyzer] Display the checker name in the text output

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "display-checker-name", +"Display the checker name for textual outputs", +true) + ---

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "display-checker-name", +"Display the checker name

[PATCH] D76605: [analyzer] Display the checker name in the text output

NoQ added a comment. Sounds great! Does the checker name get printed on the final note as well in text output? We should probably test it. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:98 const PathDiagnostic *PD = *I; + std::string WarningMsg = + (ShouldDisplayCheckerName ? " [" + PD->getCheckerName() +

[PATCH] D76605: [analyzer] Display the checker name in the text output

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:98 const PathDiagnostic *PD = *I; + std::string WarningMsg = + (ShouldDisplayCheckerName ? " [" + PD->getCheckerName() + "]" : "") `StringRef`? `getC

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus created this revision. Szelethus added reviewers: NoQ, baloghadamsoftware, balazske, martong, xazax.hun, dcoughlin, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sid