[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

2021-01-21 Thread Whisperity via Phabricator via cfe-commits
whisperity abandoned this revision. whisperity added a comment. Obsolete. There was no community consensus, or even a large enough discussion about this. What's more, the only dependee of this patch has superseded in ellegance, dropping the need for this group. Repository: rG LLVM Github Mon

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

2020-03-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D76545#1936389 , @whisperity wrote: > In D76545#1935603 , @aaron.ballman > wrote: > > > I think we want to keep the experimental checks grouped to their parent > > module rather t

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

2020-03-23 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. @aaron.ballman @njames93 Should I write up a pitch mail to cfe-dev about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76545/new/ https://reviews.llvm.org/D76545 ___ c

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

2020-03-23 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. In D76545#1935603 , @aaron.ballman wrote: > I think we want to keep the experimental checks grouped to their parent > module rather than being in a module of their own. For this, wouldn't the fact that telling Tidy to enable

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

2020-03-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I think we want to keep the experimental checks grouped to their parent module rather than being in a module of their own. Also, if we want to allow experimental checks, I think we should have some rough community consensus on 1) what are the criteria for somethin

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

2020-03-21 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I'm not sold on this being necessary as there is nothing against simply putting the check in the right module to begin with, then changing the registerCheck call to `experimenal-` as well as the docs. Could even do some fancy trickery with the python scripts to add sup

[PATCH] D76545: [clang-tidy] Add a new check group 'experimental-'

2020-03-21 Thread Whisperity via Phabricator via cfe-commits
whisperity created this revision. whisperity added a reviewer: aaron.ballman. whisperity added a project: clang-tools-extra. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, arphaman, dkrupp, rnkovacs, xazax.hun, mgorny. Herald added a project: clang. whisperity added a parent