[PATCH] D76385: Allow remapping Clang module include paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG22d5bd0e3b32: Allow remapping Clang module include paths (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llv

[PATCH] D76385: Allow remapping Clang module include paths

aprantl added a comment. LLDB didn't apply DW_AT_comp_dir to DW_AT_LLVM_include_path. I fixed that now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 ___ cfe-

[PATCH] D76385: Allow remapping Clang module include paths

aprantl added a comment. I'll update this with either a fix in clang or a patch to lldb once I figured out what happened. http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/13054/testReport/junit/lldb-api/lang_cpp_modules-import/TestCXXModulesImport_py/ Repository: rG LLVM Github Monor

[PATCH] D76385: Allow remapping Clang module include paths

aprantl added a comment. Herald added a subscriber: ormris. I had to revert this because it unexpectedly broke the "expr -- @import Module" test in LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 _

[PATCH] D76385: Allow remapping Clang module include paths

This revision was automatically updated to reflect the committed changes. Closed by commit rGdca920a904c2: Allow remapping Clang module include paths (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D76385: Allow remapping Clang module include paths

aprantl updated this revision to Diff 251789. aprantl added a comment. Rebased and addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Modules/debug-info-moduleimport

[PATCH] D76385: Allow remapping Clang module include paths

shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2487 + // Return a StringRef to the remapped Path. + auto RemapPath = [&](std::string Path) -> std::string { +Path = remapDIPath(Path); `&` -> `&TheCU` We should try to explicitly

[PATCH] D76385: Allow remapping Clang module include paths

aprantl updated this revision to Diff 251411. aprantl added a comment. Don't try to be too clever. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Modules/debug-info-moduleimport.m Index:

[PATCH] D76385: Allow remapping Clang module include paths

JDevlieghere added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2488 + auto RemapPath = [&](std::string &Path) { +Path = remapDIPath(Path); +StringRef Relative(Path); aprantl wrote: > Is this legal? > > remapDIPath takes a StringRef to

[PATCH] D76385: Allow remapping Clang module include paths

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2488 + auto RemapPath = [&](std::string &Path) { +Path = remapDIPath(Path); +StringRef Relative(Path); Is this legal? remapDIPath take

[PATCH] D76385: Allow remapping Clang module include paths

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere. rdar://problem/55685132 https://reviews.llvm.org/D76385 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Modules/debug-info-moduleimport.m Index: clang/test/Modules/debug-info-moduleimport.m ==