[PATCH] D76346: [Syntax] Build template declaration nodes

2020-03-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Reverted in 881f5b5a7b2 for now. Usually the fix is to add -fno-delayed-template-parsing somewhere, but in this case it seems like the whole feature might not expect delayed template parsing, so maybe

[PATCH] D76346: [Syntax] Build template declaration nodes

2020-03-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Breaks tests on Windows: http://45.33.8.238/win/10716/step_7.txt Please take a look and revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76346/new/ https://reviews.llvm.org/D76346

[PATCH] D76346: [Syntax] Build template declaration nodes

2020-03-18 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd12826808f9: [Syntax] Build template declaration nodes (authored by hlopko, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D76346?vs=251095&id=251100#toc Repository: rG L

[PATCH] D76346: [Syntax] Build template declaration nodes

2020-03-18 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko updated this revision to Diff 251095. hlopko added a comment. Clang tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76346/new/ https://reviews.llvm.org/D76346 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax