[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

2020-03-18 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGbd763e2cf7c1: [clang] Fix crash on visiting null nestedNameSpecifier. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

2020-03-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 251006. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76320/new/ https://reviews.llvm.org/D76320 Files: clang/lib/Sema/

[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

2020-03-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:5926 const DependentNameType* T) { - return VisitNestedNameSpecifier(T->getQualifier()); + if (auto *Q = T->ge

[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

2020-03-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:5926 const DependentNameType* T) { - return VisitNestedNameSpecifi

[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

2020-03-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. Fix https://github.com/clangd/clangd/issues/293 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76320 Files: clang/li