[PATCH] D76295: Use 64 bit integers for bit offsets inside AST file

2020-03-17 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. In D76295#1927041 , @aganea wrote: > Hello Dmitry! Could we use varints > > instead of uint64_t if size on disk is a concern? Variants are very close

[PATCH] D76295: Use 64 bit integers for bit offsets inside AST file

2020-03-17 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. Hello Dmitry! Could we use varints instead of uint64_t if size on disk is a concern? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76295/new/ https://r

[PATCH] D76295: Use 64 bit integers for bit offsets inside AST file

2020-03-17 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added a project: clang. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. This diff is for discussion how to address problem with large preamble file. 32 bit offsets can be used for PCH/preamble files below 512M. This diff fixes cra