[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe80b81d1cbf8: [Support] Fix formatted_raw_ostream for UTF-8 (authored by ostannard). Repository: rG LLVM Github Monorep

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

This revision was automatically updated to reflect the committed changes. Closed by commit rGe80b81d1cbf8: [Support] Fix formatted_raw_ostream for UTF-8 (authored by ostannard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://review

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard updated this revision to Diff 275029. ostannard marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291 Files: clang/test/Analysis/checker-plugins.c llvm/include/llvm/S

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

kristof.beyls added a comment. Herald added a project: LLVM. This looks fine to me; I just have a number of nit picks. The only part where I don't understand the code logic is around the comment starting with "If this is the final byte of a multi-byte sequence". Comment at: ll

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard added a reviewer: kristof.beyls. ostannard added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291 ___ cfe-commits mailing list cfe-com

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hubert.reinterpretcast added a comment. I have no further concerns with this patch (although I would suggest editing the description to use "Unicode" capitalized). I will leave approval of the patch to one of the requested reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard updated this revision to Diff 251105. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291 Files: clang/test/Analysis/checker-plugins.c llvm/include/llvm/Support/FormattedStream.h llvm/lib/Support/

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/FormattedStream.cpp:59 +size_t NumBytes = getNumBytesForUTF8(PartialUTF8Char[0]); +if (NumBytes > (PartialUTF8Char.size() + Size)) { + // If we still don't have enough bytes for a complete cod

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard updated this revision to Diff 251030. ostannard added a comment. - I managed to reproduce the lsl-zero.s test failure on windows, this turned out to be because the test merges stdout and stderr, which can result in them being interleaved in ways which breaks tests. The test doesn't che

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard marked 16 inline comments as done. ostannard added inline comments. Comment at: llvm/unittests/Support/formatted_raw_ostream_test.cpp:88 + +TEST(formatted_raw_ostreamTest, Test_UTF8) { + SmallString<128> A; hubert.reinterpretcast wrote: > Should there

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hoyFB added inline comments. Comment at: clang/test/Analysis/checker-plugins.c:120 +// CHECK-CHECKER-OPTION-HELP-SAME: example checker opt. (default: +// CHECK-CHECKER-OPTION-HELP-NEXT: false) LGTM, thanks for fixing this! Repository: rG LLVM Github Monorepo

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/FormattedStream.cpp:64 +} else { + // The first few bytes from the buffer will complete the code-point. + // Concatenate them and process their effect on the line ane column

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hubert.reinterpretcast added inline comments. Comment at: llvm/include/llvm/Support/FormattedStream.h:44 + /// PartialUTF8Char - Either empty or a prefix of a UTF-8 character which + /// should be prepended to the buffer for the next call to ComputePosition.

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

benlangmuir added inline comments. Comment at: llvm/include/llvm/Support/FormattedStream.h:49 + /// once we have the rest of it. + SmallString<4> PartialUTF8Char; + The changes related to `PartialUTF8Char` LGTM, thanks! Repository: rG LLVM Github Monorepo

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard created this revision. ostannard added reviewers: MaskRay, thakis, hoyFB, benlangmuir. Herald added subscribers: cfe-commits, dexonsmith, hiraditya. Herald added a project: clang. - The getLine and getColumn functions need to update the position, or they will return stale data for buffe