[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl added a comment. In D76262#1930297 , @thakis wrote: > Could you add a clang-side test for the check-mlir fix? Having to run mlir > tests to verify clang changes seems suboptimal, so we should try to improve > coverage of clang's tests. test adde

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl added a comment. In D76262#1930297 , @thakis wrote: > Could you add a clang-side test for the check-mlir fix? Having to run mlir > tests to verify clang changes seems suboptimal, so we should try to improve > coverage of clang's tests. sure. wil

[PATCH] D76262: [NFC] Add UsedDeclVisitor

thakis added a comment. Could you add a clang-side test for the check-mlir fix? Having to run mlir tests to verify clang changes seems suboptimal, so we should try to improve coverage of clang's tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl added a comment. In D76262#1929918 , @jpienaar wrote: > This does not appear to be NFC: > > git checkout 704cd4d5d0754904361823588f203369c309deca ; ninja check-mlir > passes > git checkout 08ab8c9af4dd27cb306b449edc9a9c50ed11194a ; ninja check-

RE: [PATCH] D76262: [NFC] Add UsedDeclVisitor

...@skidmore.edu; blitzrak...@gmail.com; shen...@google.com Subject: [PATCH] D76262: [NFC] Add UsedDeclVisitor [CAUTION: External Email] jpienaar added a comment. This does not appear to be NFC: git checkout 704cd4d5d0754904361823588f203369c309deca <https://nam11.safelinks.protection.outlook.

[PATCH] D76262: [NFC] Add UsedDeclVisitor

jpienaar added a comment. This does not appear to be NFC: git checkout 704cd4d5d0754904361823588f203369c309deca ; ninja check-mlir passes git checkout 08ab8c9af4dd27cb306b449edc9a9c50ed11194a

[PATCH] D76262: [NFC] Add UsedDeclVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rG08ab8c9af4dd: [NFC] Add UsedDeclVisitor (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76262/new/ https:/

[PATCH] D76262: [NFC] Add UsedDeclVisitor

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76262/new/ https://reviews.llvm.org/D76262 ___ cfe-commits mailing list

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl added inline comments. Comment at: clang/lib/Sema/UsedDeclVisitor.h:43 + asImpl().visitUsedDecl(E->getMemberLoc(), D); +} + } rjmccall wrote: > You need to recurse on the base expression here. (And that's a good test > case for your own patch!)

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl updated this revision to Diff 250688. yaxunl marked 2 inline comments as done. yaxunl added a comment. visit base expr of member expr. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76262/new/ https://reviews.llvm.org/D76262 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/U

[PATCH] D76262: [NFC] Add UsedDeclVisitor

rjmccall added a comment. Thanks, looks good except for one oversight. Comment at: clang/lib/Sema/UsedDeclVisitor.h:43 + asImpl().visitUsedDecl(E->getMemberLoc(), D); +} + } You need to recurse on the base expression here. (And that's a good test cas

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl created this revision. yaxunl added a reviewer: rjmccall. This patch is extracted from https://reviews.llvm.org/D70172 https://reviews.llvm.org/D76262 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/UsedDeclVisitor.h Index: clang/lib/Sema/UsedDeclVisitor.h