This revision was automatically updated to reflect the committed changes.
Closed by commit rG7d382dcd46a1: [Syntax] Build declarator nodes (authored by
hlopko, committed by gribozavr).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76220/new/
https:/
gribozavr2 accepted this revision.
gribozavr2 added a comment.
BTW, would be also nice to have tests for trailing return types not at the top
level -- in a follow-up:
`auto x(char a, auto (*b)(int) -> short) -> void;`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
hlopko updated this revision to Diff 250591.
hlopko added a comment.
Fix clang tidy warning.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76220/new/
https://reviews.llvm.org/D76220
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/T
hlopko updated this revision to Diff 250574.
hlopko marked 8 inline comments as done.
hlopko added a comment.
Resolving comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76220/new/
https://reviews.llvm.org/D76220
Files:
clang/include/clang
hlopko added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:522
+/// `(volatile int a)` in `int foo(volatile int a);`
+/// `(int&& a)` in `int foo(int&& a);`
+/// `() -> int` in `auto foo() -> int;`
gribozavr2 wrote:
> I meant:
>
> `i
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:519
+
+/// Parameter list for a function type.
+/// E.g.:
... and a trailing return type, if the function has one.
Comment at: clang/include/clang/Tooling/