[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGba1ffd25c1f7: [OpenMP][NFC] Remove the need to include `OpenMPClause.h` (authored by rnk). Changed prior to commit: htt

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk commandeered this revision. rnk edited reviewers, added: jdoerfert; removed: rnk. rnk added a comment. This revision now requires review to proceed. I got it building... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.l

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk updated this revision to Diff 254889. rnk added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. - seems to build all.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.llvm.org/D76184 Files:

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk added a comment. In D76184#1956352 , @jdoerfert wrote: > @rnk What is the plan for this one now? Should I abandon it? Sorry, I got distracted. I tried reapplying it but it didn't apply cleanly. It's possible I hadn't locally applied your patch serie

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert added a comment. Herald added a subscriber: yaxunl. @rnk What is the plan for this one now? Should I abandon it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.llvm.org/D76184 _

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert added a comment. In D76184#1927159 , @rnk wrote: > I patched this in with it's dependency, and to compile just Attr.h by itself, > it reduces the time from ~2.420s to ~1.920s, so it is worth pushing this > through. :) > > However, I noticed tha

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert added a comment. In D76184#1927159 , @rnk wrote: > I patched this in with it's dependency, and to compile just Attr.h by itself, > it reduces the time from ~2.420s to ~1.920s, so it is worth pushing this > through. :) > > However, I noticed tha

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk added a comment. I patched this in with it's dependency, and to compile just Attr.h by itself, it reduces the time from ~2.420s to ~1.920s, so it is worth pushing this through. :) However, I noticed that there are still some targets broken by the removal of the SmallSet.h include. I'm happ

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.llvm.org/D76184

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert updated this revision to Diff 250396. jdoerfert added a comment. Finish changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.llvm.org/D76184 Files: clang/include/clang/AST/Attr.h clang/include/clang/AST/Op

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert created this revision. jdoerfert added a reviewer: rnk. Herald added subscribers: guansong, bollu. Herald added a project: clang. See rational here: https://reviews.llvm.org/D76173#1922916 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76184 Files: clang/include/cl