[PATCH] D76097: improve performance of getSDKName()

2020-03-21 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. @JDevlieghere it's an annoying bug in Phab, but if you approve a patch without providing any textual message, Phab doesn't send email to the mailing list - so it ends up looking like something's committed without approval (if you're just looking at the mailing list). S

[PATCH] D76097: improve performance of getSDKName()

2020-03-20 Thread Adrian Prantl via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e916bf9f5e4: Driver: Improve performance of getSDKName() (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D76097: improve performance of getSDKName()

2020-03-12 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl created this revision. aprantl added a reviewer: arphaman. Herald added a subscriber: dexonsmith. The ".sdk" component is usually the last one in the -isysroot, so it makes more sense to scan from the back. Also, technically, someone could install Xcode into a directory ending with .sdk,