[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

This revision was automatically updated to reflect the committed changes. Closed by commit rG7420f96924a3: [TableGen] Move generated *Attr class methods out of line (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D76040?vs=249817&id=249956#toc Repository: rG LLVM Github

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rnk added a comment. In D76040#1919170 , @aaron.ballman wrote: > LGTM as well, though please run clang-format over the patch (some of the > formatting looks to have gone weird in places). Thanks, done. I undid some of its more questionable reformatting

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well, though please run clang-format over the patch (some of the formatting looks to have gone weird in places). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76040/new/

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76040/new/ https://reviews.llvm.org/D76040 __

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rnk marked an inline comment as done. rnk added a comment. The main things going out of line are: - Create* factory methods - Constructors - Enum/string converters (use StringSwitch -> slow to instantiate) Here's two examples from before & after: https://reviews.llvm.org/P8203 https://reviews.ll

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rjmccall added a comment. Are there any classes of methods which are worth continuing to generate inline? Surely some of the accessors are trivial. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76040/new/ https://reviews.llvm.org/D76040 __

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rnk created this revision. rnk added reviewers: aaron.ballman, rjmccall, jdoerfert. Herald added a project: clang. After this change, clang spends ~200ms parsing Attrs.inc instead of ~560ms. A large part of the cost was from the StringSwitch instantiations, but this is a good way to avoid similar