[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

sdesmalen added a comment. Addressed review comments before commititng. Thanks for the review @miyuki and @SjoerdMeijer! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75861/new/ https://reviews.llvm.org/D75861 _

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

This revision was automatically updated to reflect the committed changes. sdesmalen marked 4 inline comments as done. Closed by commit rG981f0802b375: [SVE] Generate overloaded functions for ACLE intrinsics. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D75861?vs=24

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. With the nit addressed, this LGTM Comment at: clang/utils/TableGen/SveEmitter.cpp:634 " *\n" " * Permission is hereby granted, free of charge, t

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/Attr.td:362 +def TargetAArch64 : TargetArch<["aarch64"]>; +def TargetARM_AArch64 : TargetArch; def TargetAVR : TargetArch<["avr"]>; nit: don't thin we use underscores in names, and looking

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

miyuki added a comment. The clang attribute part LGTM, but I want someone else to check the rest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75861/new/ https://reviews.llvm.org/D75861 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

sdesmalen updated this revision to Diff 249404. sdesmalen added a comment. - Refactored condition to check for valid builtins (split up checks for Arm and AArch64) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75861/new/ https://reviews.llvm.org/D75861 Files: clang/include/clang/Bas

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

miyuki added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5002 if (!ArmMveAliasValid(BuiltinID, AliasName) && + !ArmCdeAliasValid(BuiltinID, AliasName) && I would suggest splitting the check into Arm-specific and AArch64-specific checks

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

sdesmalen updated this revision to Diff 249370. sdesmalen edited the summary of this revision. sdesmalen added a comment. - Rebased patch on top of D75850 . - Removed `__clang_arm_sve_alias` in favour of `__clang_arm_builtin_alias` CHANGES SINCE LAST ACTION htt

[PATCH] D75861: [SVE] Generate overloaded functions for ACLE intrinsics.

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, miyuki, efriedma, simon_tatham. Herald added subscribers: cfe-commits, danielkiss, dmgreen, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. The SVE ACLE allows usi