This revision was automatically updated to reflect the committed changes.
Closed by commit rGcdeeb548bbeb: [ARM,CDE] Implement CDE feature test macros
(authored by miyuki).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75843/new/
https://reviews.llv
miyuki updated this revision to Diff 249115.
miyuki added a comment.
Fix condition check
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75843/new/
https://reviews.llvm.org/D75843
Files:
clang/include/clang/Basic/TargetInfo.h
clang/lib/Basic/TargetInfo.cpp
clang/lib/Basic/Targets/A
miyuki marked an inline comment as done.
miyuki added inline comments.
Comment at: clang/lib/Basic/Targets/ARM.cpp:492
HW_FP |= HW_FP_SP | HW_FP_HP;
+} else if (Feature >= "+cdecp0" && Feature <= "+cdecp7") {
+ unsigned Coproc = Feature.back() - '0';
-
simon_tatham added inline comments.
Comment at: clang/lib/Basic/Targets/ARM.cpp:492
HW_FP |= HW_FP_SP | HW_FP_HP;
+} else if (Feature >= "+cdecp0" && Feature <= "+cdecp7") {
+ unsigned Coproc = Feature.back() - '0';
As far as I can see, feature na
miyuki updated this revision to Diff 249103.
miyuki added a comment.
Fixed typos and formatting.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75843/new/
https://reviews.llvm.org/D75843
Files:
clang/include/clang/Basic/TargetInfo.h
clang/lib/Basic/TargetInfo.cpp
clang/lib/Basic/T
simon_tatham requested changes to this revision.
simon_tatham added inline comments.
This revision now requires changes to proceed.
Comment at: clang/include/clang/Basic/TargetInfo.h:213
+ unsigned ARMCDECorpocMask : 8;
+
Typo: `Corpoc` → `Coproc`. Lots of tho
miyuki created this revision.
miyuki added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM.
Herald added subscribers: cfe-commits, danielkiss, kristof.beyls.
Herald added a project: clang.
This patch implements feature test macros for the CDE extension
according to the upcoming ACLE spe
