[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

This revision was automatically updated to reflect the committed changes. rnk marked an inline comment as done. Closed by commit rGc915cb957dc3: Avoid including Module.h from ExternalASTSource.h (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. Thanks! In D75784#1917181 , @aprantl wrote: > To avoid bot breakage, I would recommend testing -DLLVM_ENABLE_MODULES=1 > stage2 build works before landing this, as it is notoriously sensitive to > header reshuffling. Good idea, I

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aprantl added a comment. To avoid bot breakage, I would recommend testing -DLLVM_ENABLE_MODULES=1 stage2 build works before landing this, as it is notoriously sensitive to header reshuffling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75784/new

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from minor nits, this seems reasonable to me, LG! Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:16 #include "llvm/ADT/StringR

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk added a comment. In D75784#1910688 , @aprantl wrote: > This will no doubt also need some patches to the Swift compiler, but given > the NFC-ness this hopefully should be fine. True. I could leave behind a typedef for the ASTSourceDescriptor if it ma

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aprantl added a comment. This will no doubt also need some patches to the Swift compiler, but given the NFC-ness this hopefully should be fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75784/new/ https://reviews.llvm.org/D75784 ___

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk created this revision. rnk added reviewers: aaron.ballman, hans. Herald added projects: clang, LLDB. Herald added a subscriber: lldb-commits. Module.h takes 86ms to parse, mostly parsing the class itself. Avoid it if possible. ASTContext.h depends on ExternalASTSource.h. A few NFC changes wer