aeubanks added a comment.
Specifically regarding
../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller
integer type 'unsigned long' from 'void *',
I sent out a change to fix that:
https://chromium-review.googlesource.com/c/chromium/src/+/2091215, and tried
compiling with ToT
rnk added a comment.
I agree with the reasoning, but this is likely to fire all over existing C++
code. In fact, the one we just added finds issues in Chrome
https://ci.chromium.org/p/chrome/builders/ci/ToTWin/5879
../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller
integer
aeubanks created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
aeubanks edited the summary of this revision.
aeubanks added reviewers: thakis, rnk.
aeubanks retitled this revision from "Move warnings added in
https://reviews.llvm.org/D75708 under -Wmicrosoft
