[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-15 Thread Nandor Licker via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb3387d1c30ae: [ConstExprPreter] Updated constant interpreter documentation (authored by nand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ http

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-15 Thread Nandor Licker via Phabricator via cfe-commits
nand updated this revision to Diff 257637. nand marked 2 inline comments as done. nand added a comment. fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 Files: clang/docs/ConstantInterpreter.rs

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thanks! I'm happy for you to go ahead landing patches that implement the direction documented here. (Let me know if you want me to review them anyway,

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-09 Thread Nandor Licker via Phabricator via cfe-commits
nand added a comment. Thanks for the comments! I tried to clarify what could be done in the future and what is already supported. Comment at: clang/docs/ConstantInterpreter.rst:174 A block containing a primitive reserved storage only for the primitive.

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-09 Thread Nandor Licker via Phabricator via cfe-commits
nand updated this revision to Diff 256346. nand marked 15 inline comments as done. nand added a comment. addressed comments, fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 Files: clang/docs/C

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-04-07 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/docs/ConstantInterpreter.rst:118 Memory management in the interpreter relies on 3 data structures: ``Block`` -object which store the data and associated inline metadata, ``Pointer`` objects -which refer to or into blocks, and ``Des

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-03-12 Thread Nandor Licker via Phabricator via cfe-commits
nand updated this revision to Diff 249992. nand added a comment. Wrapped to ~80 chars/line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 Files: clang/docs/ConstantInterpreter.rst Index: clang/docs/Cons

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-03-06 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. This file needs linewrapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

2020-03-06 Thread Nandor Licker via Phabricator via cfe-commits
nand created this revision. nand added reviewers: rsmith, Bigcheese, dexonsmith, jfb. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updated the documentation to better reflect features implemented on the constexpr branch at https://github.com/nandor/llvm-project and extend