[PATCH] D75606: [clang-format] Improve identification of C# nullables

2020-03-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfe61bc1a0b5a: [clang-format] Improve identification of C# nullables (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D75606: [clang-format] Improve identification of C# nullables

2020-03-04 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 248232. jbcoe marked an inline comment as done. jbcoe added a comment. Remove duplicate check following review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75606/new/ https://reviews.llvm.org/D75606 Files: clang/lib/Format/TokenAnnotator.

[PATCH] D75606: [clang-format] Improve identification of C# nullables

2020-03-04 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good with 1 suggestion. Comment at: clang/lib/Format/TokenAnnotator.cpp:1018 + (Tok->Next && Tok->Next->is(tok::identifier) && Tok->Next->Next && +

[PATCH] D75606: [clang-format] Improve identification of C# nullables

2020-03-04 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider `? identifier =` and `? identifier;` to be nullable within function bodies. Repository: rG LLVM Github Monorepo