This revision was automatically updated to reflect the committed changes.
Closed by commit rG2b366e75d413: Make Decl::setOwningModuleID() public. (NFC)
(authored by aprantl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
shafik accepted this revision.
shafik added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75560/new/
https://reviews.llvm.org/D75560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
I'm surprised so few setters needed to be made public for this to work. If this
required making lots more setters public, I'd be concerned, because we
generally don't want large chunks of the
aprantl marked an inline comment as done.
aprantl added inline comments.
Comment at: clang/include/clang/AST/DeclBase.h:629-630
+public:
+ void setFromASTFile() { FromASTFile = true; }
+
rsmith wrote:
> Setting this after creating a `Decl` is not safe in gener
aprantl updated this revision to Diff 248618.
aprantl added a comment.
I took your suggestion to heart and changed the downstream LLDB patch to use
CreateDeserialized() everywhere, which is frankly a better fit there anyway. To
make this possible I had to make a few more setters public, see the
rsmith added inline comments.
Comment at: clang/include/clang/AST/DeclBase.h:629-630
+public:
+ void setFromASTFile() { FromASTFile = true; }
+
Setting this after creating a `Decl` is not safe in general; declarations with
this flag set have 8 bytes of additi
