[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG900dee8c8e03: [clang-format] Do not merge target-name and : for C# attributes (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you for the explanations! Looking good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75465/new/ https://reviews.llvm.org/D75465 _

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

MyDeveloperDay added a comment. This feels better than merging I think visual studio tends to create files via the new project wizard that do not have a space before but do have a space after the `:` [assembly: ComVisible(false)] CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75465/new

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

jbcoe updated this revision to Diff 247832. jbcoe marked 2 inline comments as done. jbcoe added a comment. Do not allow spaces around C# attribute colons. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75465/new/ https://reviews.llvm.org/D75465 Files: clang/lib/Format/FormatTokenLexer

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

jbcoe added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:391 if (!AttrTok) - return false; + return true; This is needed to avoid ``` [assembly:InternalsVisibleTo("SomeAssembly, PublicKey=SomePublicKeyThatExceedsTheColumnLi

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

krasimir added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:281 Style.ColumnLimit = 10; - verifyFormat(R"([assembly:InternalsVisibleTo( + verifyFormat(R"([assembly: InternalsVisibleTo( "SomeAssembly, PublicKey=SomePublicKeyThatExceedsTheColum

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

krasimir added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:281 Style.ColumnLimit = 10; - verifyFormat(R"([assembly:InternalsVisibleTo( + verifyFormat(R"([assembly: InternalsVisibleTo( "SomeAssembly, PublicKey=SomePublicKeyThatExceedsTheColum

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Re-use token type `TT_AttributeColon` for C# attribute target colons. Repository: rG LLVM Github Monorepo https://reviews.