[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG9619c2cc9a22: [clang][Syntax] Handle macro arguments in spelledForExpanded (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D75446?vs=

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:201 + /// Returns the subrange of spelled tokens corresponding to AST node spanning + /// \p Expanded.

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet updated this revision to Diff 253325. kadircet added a comment. - Rebase, update comments for spelledForExpanded and add tests for multiple arguments. - Do not dive into macro bodies while looking for a common expansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet added a comment. In D75446#1924496 , @sammccall wrote: > I think per offline discussion, this was going to have some additional docs > clarifying the contracts of this function, and maybe extra tests? > > The conclusion IIRC was that this functio

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

sammccall added a comment. I think per offline discussion, this was going to have some additional docs clarifying the contracts of this function, and maybe extra tests? The conclusion IIRC was that this function is designed to find the text that you could replace in order to replace an AST node

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet added a child revision: D75447: [clangd] Make use of token buffers in semantic highlighting. Repository: rG LLVM Github Monorepo https://reviews