[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-03-11 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe08464fb4504: Avoid including FileManager.h from SourceManager.h (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D75406?vs=247479&id=249752#toc Repository: rG LLVM Github Monorep

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-03-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ cfe-commits mailing list cfe-commi

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-03-11 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ cfe

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-03-10 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-02-29 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 247479. rnk added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - fixes on Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 Files:

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-02-29 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: arphaman, hans. Herald added subscribers: martong, usaxena95, jsji, kadircet, dexonsmith, jkorous, kbarton, nemanjai. Herald added a project: clang. Most clients of SourceManager.h need to do things like turning source locations into file & line num