ashi009 added a comment.
Any update on this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
https://reviews.llvm.org/D75323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
vsapsai added a comment.
There is nothing in header maps preventing from using relative paths. For
example, I was able to run one of the tests with relative paths like
./bin/clang -cc1 -fsyntax-only
../../../llvm-project/clang/test/Preprocessor/headermap-rel.c -I
./tools/clang/test/Preproces
thakis added a comment.
I don't know why we (chromium) want to use header maps, but assuming we do want
to use them: The problem with absolute paths is that they're machine-dependent
and can't be run on other machines and then cached globally. See also
http://blog.llvm.org/2019/11/deterministic
vsapsai added a comment.
The issue with this change is that it claims to add functionality that exists
already. I.e., the test is passing without the change. The confusing part might
be that even if `DirectoryLookup::LookupFile` doesn't find a file for relative
destination immediately, it updat
rnk added a comment.
For more context: https://crbug.com/1056174
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
https://reviews.llvm.org/D75323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
rnk added a comment.
@vsapsai @bruno The use case is distributed compilation. I am unfamiliar with
the changes in question, but essentially, if every input to clang is rooted in
/Users/foo and the build works there, we should be able to move it all to
/Users/bar, change directories, and the bui
bruno requested changes to this revision.
bruno added a comment.
This revision now requires changes to proceed.
I also want to understand why you want this change. I'm not convinced this is
the behavior we want and it's not like we encourage people to use header maps
in the first place. I'd be f
vsapsai added a comment.
What use case are you trying to support? Currently the added test
`headermap_relpath.cpp` is passing without the changes to `HeaderSearch.cpp`,
so it's not entirely clear what problem it should address.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
takuto.ikuta added a comment.
Nico, can we merge this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
https://reviews.llvm.org/D75323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
sque updated this revision to Diff 247558.
sque added a comment.
Format json according to RFC 8259 (https://jsonformatter.curiousconcept.com/)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
https://reviews.llvm.org/D75323
Files:
clang/lib/Lex/HeaderSearch.cpp
clang/test/H
takuto.ikuta added inline comments.
Comment at: clang/test/Headers/Inputs/headermap_relpath/empty.hmap.json:1
+{"mappings":{"empty/empty.h":"include/empty.h"}}
better to format like other hmap.json?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/ne
sque updated this revision to Diff 247554.
sque added a comment.
Delete unnecessary comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
https://reviews.llvm.org/D75323
Files:
clang/lib/Lex/HeaderSearch.cpp
clang/test/Headers/Inputs/headermap_relpath/empty.hmap.json
c
sque updated this revision to Diff 247540.
sque marked an inline comment as done.
sque added a comment.
Changed to generate hmap file using hmaptool.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
https://reviews.llvm.org/D75323
Files:
clang/lib/Lex/HeaderSearch.cpp
clang
sque marked an inline comment as done.
sque added inline comments.
Comment at: clang/test/Headers/headermap_relpath.cpp:8
+
+// RUN: cd %S; %clang_cc1 -I %S/Inputs/empty.hmap %s
+
takuto.ikuta wrote:
> generate header map using hmaptool like
> https://github.com/
takuto.ikuta added inline comments.
Comment at: clang/test/Headers/headermap_relpath.cpp:8
+
+// RUN: cd %S; %clang_cc1 -I %S/Inputs/empty.hmap %s
+
generate header map using hmaptool like
https://github.com/llvm/llvm-project/blob/e32ff096858578f526b6d05ab97c8f08
sque updated this revision to Diff 247177.
sque edited the summary of this revision.
sque added a comment.
Added test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
https://reviews.llvm.org/D75323
Files:
clang/lib/Lex/HeaderSearch.cpp
clang/test/Headers/Inputs/empty.hmap
takuto.ikuta requested changes to this revision.
takuto.ikuta added a comment.
This revision now requires changes to proceed.
add test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75323/new/
https://reviews.llvm.org/D75323
sque created this revision.
sque added reviewers: vsapsai, arphaman, akyrtzi.
Herald added subscribers: cfe-commits, dexonsmith.
Herald added a project: clang.
Existing behavior:
- If hmap dest path is absolute: = Look for the file and return it as result. =
If file not found, return None.
- If
18 matches
Mail list logo
