[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-28 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Probably worth a mention in clang/docs/ReleaseNotes.rst, and maybe we should call it out in the user manual too, similarly to what we do for /Zc:dllexportInlines- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75093/new/ http

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-25 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbcda1269c4c4: clang-cl: Add a `/showIncludes:user` flag. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D75093#1891067 , @thakis wrote: > This is what -MD passes (which is why the -sys flag already exists), and more > orthogonal flags instead of fewer, tangled ones is what we usually go for at > the cc1 layer. So I like it more as

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-25 Thread Nico Weber via Phabricator via cfe-commits
thakis updated this revision to Diff 246417. thakis added a comment. add one more test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75093/new/ https://reviews.llvm.org/D75093 Files: clang/include/clang/Driver/CLCompatOptions.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Fro

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-25 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This is what -MD passes (which is why the -sys flag already exists), and more orthogonal flags instead of fewer, tangled ones is what we usually go for at the cc1 layer. So I like it more as is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75093/new/ https://r

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-25 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Instead of replacing the old cc1 "--show-includes" with "--show-includes -sys-header-deps" -- which looks a little ugly maybe -- would it be simpler to just introduce a new cc1 flag instead, e.g. "--show-user-includes", and just expand /showIncludes:user to that? CHANGES

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-24 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. This flag is like /showIncludes, but it only includes user headers and omits system headers (similar to MD and MMD). The motivation is that projects that already track system includes though other means can use this flag to get consis