[PATCH] D75053: [clangd] Disable ExtractVariable for C

2020-02-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG555d5ad85a49: [clangd] Disable ExtractVariable for C (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75053/new/ https://reviews.llvm.o

[PATCH] D75053: [clangd] Disable ExtractVariable for C

2020-02-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 246406. kadircet marked an inline comment as done. kadircet added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75053/new/ https://reviews.llvm.org/D75053 Files: clang-tools-extr

[PATCH] D75053: [clangd] Disable ExtractVariable for C

2020-02-25 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:453 const ASTContext &Ctx = Inputs.AST->getASTContext(); + // FIXME: Enable C (and mayb

[PATCH] D75053: [clangd] Disable ExtractVariable for C

2020-02-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently extract variable doesn't spell the type explicitly and just uses an `auto` instead, which is not availab