[PATCH] D75006: Wrap lines for C# property accessors

2020-02-24 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, thank you for the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006

[PATCH] D75006: Wrap lines for C# property accessors

2020-02-24 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 246170. jbcoe added a comment. Handle C# access modifier `internal `. Fix typo in test for expression-bodied get/set methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 Files: clang/lib/Format/Unwrappe

[PATCH] D75006: Wrap lines for C# property accessors

2020-02-23 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:443 +if (GetToken && +GetToken->isOneOf(tok::kw_public, tok::kw_protected, tok::kw_private)) + GetToken = GetToken->Next; I think we need to consider `i

[PATCH] D75006: Wrap lines for C# property accessors

2020-02-22 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 246070. jbcoe added a comment. Code and test to avoid wrapping accessors with expression body definitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 Files: clang/lib/Format/UnwrappedLineFormatter.cpp