[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-22 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG56eb15a1c710: [Sema] Fix pointer-to-int-cast diagnostic for _Bool (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://r

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-22 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. In D74860#1888024 , @Mordante wrote: > In D74860#1883415 , @rjmccall wrote: > > > Can we test the same thin

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-22 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 246082. Mordante added a comment. Added some C++ tests for similar c-style casts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860 Files: clang/lib/Sema/SemaCast.cpp clang/test/Sema/MicrosoftExtensions.c

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-22 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. In D74860#1883415 , @rjmccall wrote: > Can we test the same thing in C++? I'll add some tests, but C++ uses a different codepath for c-style casts. In D74860#1883480 , @nickdesaulniers

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-19 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Also, make sure to run `git-clang-format HEAD~` on the patch, as the linter suggests. Thanks for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860 __

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Can we test the same thing in C++? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-19 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: dblaikie, rjmccall, rsmith, nathanchance, nickdesaulniers. Mordante added a project: clang. The diagnostic added in D72231 also shows a diagnostic when casting to a _Bool. This is unwanted. This patch rem