[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

aganea added a comment. @llunak Small typo: your patch fixes PR44953, not PR44958. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

dblaikie added a comment. Please simplify the test case - at least to remove the long/uppercase identifiers to use placeholder names (this avoids any accidental semantic meaning they might carry (or appear to carry, but not actually carry)). What's the failure mode this is avoiding? There's no

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

aganea added a reviewer: rsmith. aganea added a comment. I've tested this patch and it solves our original issue. Could anyone please take a look so that it can be landed & merged into 10.0? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://review

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

llunak created this revision. llunak added reviewers: hans, dblaikie. llunak added a project: clang. Herald added a subscriber: cfe-commits. In D69778 I incorrectly handled two cases (checking for -building-pch-with-obj without also checking -fmodules-codegen).