thakis added a comment.
Breaks win: http://45.33.8.238/win/9705/step_9.txt
(Or your other change that landed at the same time)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74842/new/
https://reviews.llvm.org/D74842
This revision was automatically updated to reflect the committed changes.
Closed by commit rGec7c8bae8455: [clangd] Make use of syntax tokens in
ReplayPreamble (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74842/new/
https://
kadircet updated this revision to Diff 248124.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- More annotations to the test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74842/new/
https://reviews.llvm.org/D74842
Files:
cl
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:182
+
+ auto IncTok = std::next(HashTok);
+ assert(IncTok != MainFileTokens.end());
ni
kadircet updated this revision to Diff 245962.
kadircet added a comment.
- Update comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74842/new/
https://reviews.llvm.org/D74842
Files:
clang-tools-extra/clangd/ParsedAST.cpp
clang-tools-extra/
kadircet marked 7 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:138
+ : Includes(Includes), Delegate(Delegate), SM(SM), PP(PP) {
+MainFileTokens = syntax::tokenize(SM.getMainFileID(), SM, LangOpts);
+ }
-
kadircet updated this revision to Diff 245960.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments.
- Add tests by mimicking a clang-tidy check.
- only tokenize the preamble section, not the whole file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:138
+ : Includes(Includes), Delegate(Delegate), SM(SM), PP(PP) {
+MainFileTokens = syntax::tokenize(SM.getMainFileID(), SM, LangOpts);
+ }
tokenizing the whole file an e
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Replace usage of RawLexer with syntax tokens inside ReplayPreamble.
Repository:
rG LLVM Github Mono
