[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-23 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. Committed on behalf of @hoyFB per request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/ https://reviews.llvm.org/D74814 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-23 Thread Wenlei He via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbae33a7c5a1f: IR printing for single function with the new pass manager. (authored by hoyFB, committed by wenlei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-19 Thread Hongtao Yu via Phabricator via cfe-commits
hoyFB updated this revision to Diff 245484. hoyFB added a comment. Updating D74814 : IR printing for single function with the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/ https://revie

[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-19 Thread Wenlei He via Phabricator via cfe-commits
wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. Thanks for the making the changes, it would be nice to have some consistency (the same structure) between test cases for legacy PM and new PM, e.g. `EMPTY` is only tested for legacy PM, but no

[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-19 Thread Hongtao Yu via Phabricator via cfe-commits
hoyFB updated this revision to Diff 245474. hoyFB added a comment. Updating D74814 : IR printing for single function with the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74814/new/ https://revie

[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-19 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. > Sounds good. I was trying to figure out how to invoke the new pass manager > with OPT. Is there a command line switch to do that? If you just do `opt -passes=`, it will invoke new pass manager for `opt`. See https://reviews.llvm.org/D66560 for example - that was for

[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-19 Thread Hongtao Yu via Phabricator via cfe-commits
hoyFB added a comment. In D74814#1882064 , @wenlei wrote: > Thanks for fixing this. Could you use `.ll` IR file as test case and place it > alongside with `test/Other/module-pass-printer.ll` or just reuse that one? We > can also use `opt` to invoke new p

[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-19 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. Thanks for fixing this. Could you use `.ll` IR file as test case and place it alongside with `test/Other/module-pass-printer.ll` or just reuse that one? We can also use `opt` to invoke new pass manager, so it doesn't need to be a clang test. Repository: rG LLVM Githu

[PATCH] D74814: IR printing for single function with the new pass manager.

2020-02-18 Thread Hongtao Yu via Phabricator via cfe-commits
hoyFB created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. hoyFB added a reviewer: wenlei. hoyFB added a subscriber: wenlei. The IR printing always prints out all functions in a module with the new pass manager, even with -filt