[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

2020-02-19 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Thanks for working on this. > I'm not sure how (or if it's possible) to add a test that would demonstrate > the before/after here. Happy to take advice! Yea, those are some times hard. Did you try to write a unittest that hits the assertion and trigger this case? Perhaps

[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

2020-02-18 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Thanks for working on this! I have a couple of comments inline. Comment at: clang/include/clang/Basic/Diagnostic.h:918-927 /// The ID of the current diagnostic that is in flight. /// /// This is set to std::numeric_limits::max() when there

[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

2020-02-18 Thread Neil MacIntosh via Phabricator via cfe-commits
neilmacintosh created this revision. neilmacintosh added reviewers: modocache, doug.gregor, hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, dexonsmith, ilya-biryukov. Herald added a project: clang. When running clangd, I found that occasionally, accessing a precompiled header