bruno added a comment.
Thanks for working on this.
> I'm not sure how (or if it's possible) to add a test that would demonstrate
> the before/after here. Happy to take advice!
Yea, those are some times hard. Did you try to write a unittest that hits the
assertion and trigger this case? Perhaps
dexonsmith added a comment.
Thanks for working on this! I have a couple of comments inline.
Comment at: clang/include/clang/Basic/Diagnostic.h:918-927
/// The ID of the current diagnostic that is in flight.
///
/// This is set to std::numeric_limits::max() when there
neilmacintosh created this revision.
neilmacintosh added reviewers: modocache, doug.gregor, hokein.
Herald added subscribers: cfe-commits, usaxena95, kadircet, dexonsmith,
ilya-biryukov.
Herald added a project: clang.
When running clangd, I found that occasionally, accessing a
precompiled header