[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc498198b555: [clangd] Allow renaming class templates in cross-file rename. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74709?vs=244953&id=245802#toc Repository: rG LLVM

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Okay, that is unfortunate, but I think trying to rename these classes with some inaccuracy is better than failing right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

hokein added a comment. In D74709#1882451 , @kbobyrev wrote: > I think we might still give a warning of some sort that this is known to > produce results that are not always correct. Otherwise it might feel like a > bug/unknown behavior. I agree that i

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

kbobyrev added a comment. I think we might still give a warning of some sort that this is known to produce results that are not always correct. Otherwise it might feel like a bug/unknown behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7470

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It was disabled because we don't handle explicit template specialization well (due to the index limitation). r