[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf8b0cd58dbd: [clang][Index] Visit the default parameter arguements in libindex. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74610/ne

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein added a comment. In D74610#1879054 , @kadircet wrote: > LGTM, > > just wondering though if you've tried the solution we discussed offline > regarding updating `indexTypeSourceInfo` instead of this call site, could you > mention the results in here

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, just wondering though if you've tried the solution we discussed offline regarding updating `indexTypeSourceInfo` instead of this call site, could you mention the results in here? So

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein added a comment. Looking the source code closely, we also have another code path of indexing the `ParmVarDecl` in `clang/lib/Index/IndexTypeSourceInfo.cpp`, it was called via `IndexCtx.indexTypeSourceInfo` in `handleDeclarator`. In summary: 1. default arguments will be visited if this

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein updated this revision to Diff 244968. hokein added a comment. remove an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74610/new/ https://reviews.llvm.org/D74610 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp c

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein updated this revision to Diff 244935. hokein marked 2 inline comments as done. hokein added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74610/new/ https://reviews.llvm.org/D74610 Files: clang-tools-extra/clang

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein added a comment. > I totally understand if you want to make minimal changes to the code like > this, but it would be great to simplify it a little bit without regressing > too much, currently there is a knob for function locals and then another for > parameters in declarations, then ther

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

kadircet added a comment. Oh god, this code is a mess, so many knobs, and apparently I made it worst in the past sorry for that :D I totally understand if you want to make minimal changes to the code like this, but it would be great to simplify it a little bit without regressing too much, curr

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, ilya-biryukov, kristof.beyls. Herald added a project: clang. We are missing the default parmeter arguments when IndexFunctionLocals is true. Fixes https://github.com/clangd/cl