This revision was automatically updated to reflect the committed changes.
Closed by commit rG1813fde9cc0b: [WebAssembly] Emit clangast in custom section
aligned by 4 bytes (authored by kateinoigakukun, committed by sbc100).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
kateinoigakukun added a comment.
Thanks for reviewing! Can you merge this patch? I have no commit access.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74531/new/
https://reviews.llvm.org/D74531
___
cfe-
kateinoigakukun updated this revision to Diff 380554.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74531/new/
https://reviews.llvm.org/D74531
Files:
clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
clang/test/PCH/pch-wasm.c
llvm/lib/MC/
kateinoigakukun updated this revision to Diff 380551.
kateinoigakukun added a comment.
Thank you for taking a look again. OK, I extracted `writeStringWithAlignment`
and updated comment lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74531/new/
sbc100 added inline comments.
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:374
+ // Custom sections in wasm also have a string identifier with extra paddings
+ // for alignment for special sections.
+ // TODO: support section alignment at asm and llvm level?
I
kateinoigakukun updated this revision to Diff 380283.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74531/new/
https://reviews.llvm.org/D74531
Files:
clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
clang/test/PCH/pch-wasm.c
llvm/lib/MC/
kateinoigakukun updated this revision to Diff 380282.
kateinoigakukun retitled this revision from " [WebAssembly] Emit PCH
__clang_ast in custom section" to "[WebAssembly] Emit clangast in custom
section aligned by 4 bytes".
kateinoigakukun edited the summary of this revision.
kateinoigakukun add