[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG577c9b02ab57: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang (authored by atmnpatel, committed by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D74513?vs=244334&id=244815#toc R

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

jdoerfert added a comment. In D74513#1874825 , @atmnpatel wrote: > I am unable to commit this myself, can someone commit for me? I'll do that later. Ping me if I forget please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel added a comment. I am unable to commit this myself, can someone commit for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 ___ cfe-commits mailing

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

JonChesterfield added a comment. Nice. Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel updated this revision to Diff 244334. atmnpatel added a comment. Removes specified values in favor of defaults in the DefaultKind enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 Files: cla

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

jdoerfert added a comment. One question (below) otherwise this looks good. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:358 +__OMP_DEFAULT_KIND(shared, 3) +__OMP_DEFAULT_KIND(unknown, 4) + Why 2, 3, 4? Do we really need to specify the value here?

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: llvm-commits, cfe-commits, guansong. Herald added projects: clang, LLVM. This swaps out the OpenMPDefaultClauseKind enum with a llvm::omp::DefaultKind enum which is stored in OMPConsta