[PATCH] D74411: [clangd] Query constructors in the index during rename.

hokein added a comment. In D74411#1873996 , @thakis wrote: > Doesn't build on Mac: http://45.33.8.238/mac/7949/step_4.txt sorry, it should be fixed in 9f63255a742d7ec542f94e0265eac5147213d9f8

[PATCH] D74411: [clangd] Query constructors in the index during rename.

thakis added a comment. Doesn't build on Mac: http://45.33.8.238/mac/7949/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https://reviews.llvm.org/D74411 ___ cfe-commits mailing lis

[PATCH] D74411: [clangd] Query constructors in the index during rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c5ee78de113: [clangd] Query constructors in the index during rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https:/

[PATCH] D74411: [clangd] Query constructors in the index during rename.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https://reviews.llvm.org/D74411

[PATCH] D74411: [clangd] Query constructors in the index during rename.

hokein updated this revision to Diff 244345. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https://reviews.llvm.org/D74411 Files: clang-tools-extra/cla

[PATCH] D74411: [clangd] Query constructors in the index during rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:326 + // When querying references for a class, clangd's own index will also return + // references of the corresponding class constructors, but this is not true + // for all index backends,

[PATCH] D74411: [clangd] Query constructors in the index during rename.

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:326 + // When querying references for a class, clangd's own index will also return + // references of the corresponding class constructors, but this is not true + // for all index backends

[PATCH] D74411: [clangd] Query constructors in the index during rename.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Though this is not needed when using clangd's own index, other indexes (e.g. kythe) need it, as classes and the