This revision was automatically updated to reflect the committed changes.
Closed by commit rG118abf201738: [SVE] Update API ConstantVector::getSplat() to
use ElementCount. (authored by huihuiz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74386/new
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74386/new/
https://reviews.llvm.org/D74386
___
huihuiz added inline comments.
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6542
-unsigned End = getTransitionType()->getVectorNumElements();
+auto EC = getTransitionType()->getVectorElementCount();
if (UseSplat)
efriedma wrote:
> Please write o
huihuiz updated this revision to Diff 250001.
huihuiz marked 3 inline comments as done.
huihuiz added a comment.
Addressed review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74386/new/
https://reviews.llvm.org/D74386
Files:
clang/lib
efriedma added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4497
Value *CodeGenFunction::EmitNeonSplat(Value *V, Constant *C) {
- unsigned nElts = V->getType()->getVectorNumElements();
- Value* SV = llvm::ConstantVector::getSplat(nElts, C);
+ auto EC = V->getT
huihuiz updated this revision to Diff 244546.
huihuiz marked 2 inline comments as done.
huihuiz added a comment.
Thanks Eli for the review!
Add test cases to check for size query changes in
ConstantExpr::getGetElementPtr().
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
efriedma added a comment.
This is sort of a large number of functional changes, but it's probably okay to
skip test coverage for all the simple getNumElements->getElementCount changes;
it's obvious it can't break anything.
Comment at: llvm/include/llvm/Analysis/Utils/Local.h:
huihuiz created this revision.
huihuiz added reviewers: sdesmalen, efriedma, apazos, spatel, huntergr,
willlovett.
huihuiz added a project: LLVM.
Herald added subscribers: cfe-commits, psnobl, rkruppe, hiraditya, tschuett.
Herald added a project: clang.
Support ConstantInt::get() and Constant::ge
