[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

thakis added a comment. That landed in 17b77418121139c4e8cfb050d82ead3f29db7132 . Sounds like there's more SFINAE to be fixed here, but my build is happy again. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

jlebar added a comment. In D74384#1872246 , @thakis wrote: > Looks like this broke building on windows with clang-cl as host compiler in > some situations: http://45.33.8.238/win/8160/step_4.txt I'm testing out the following fix, which we verified works

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

thakis added a comment. Looks like this broke building on windows with clang-cl as host compiler in some situations: http://45.33.8.238/win/8160/step_4.txt I'm not sure if that's a bug in the version of the host clang I'm using yet. I'll poke around a bit and let you know. Repository: rG LL

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

bkramer accepted this revision. bkramer added a comment. Push and watch the bots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://reviews.llvm.org/D74384 ___ cfe-commits mailing list cf

Re: [PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

> I joined the group; what do I do to get tests run for this? you need to upload a diff to trigger the bots > > Hope someone can verify the build on Windows. > Do you think I should go on IRC and ask? Not much help before committing, but for post-commit there is http://45.33.8.238/. Doesn't con

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

jlebar added a comment. > Such changes can be risky. Heh, well said. I feel good about it because I found two or three real bugs in clang/llvm as a result of this cleanup. But still, we've got to land it safely... I joined the group; what do I do to get tests run for this? > Hope someone ca

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

MaskRay added a comment. You may join https://reviews.llvm.org/project/view/78/ and let the bot test Linux for you.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://reviews.llvm.org/D74384 __

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Such changes can be risky. Hope someone can verify the build on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://revi