[PATCH] D74361: [Clang] Uninitialize attribute on global variables

JonChesterfield updated this revision to Diff 247127. JonChesterfield added a comment. - Rename attribute, add to hasDefiningAttr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 Files: clang/include/clang

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

JonChesterfield added a comment. It zero initialises on x86, but perhaps by coincidence rather than guarantee. Fair enough regarding reuse of the existing attribute, I'll create a new one. Thanks for the pointers on additional cases to test for too. I'll return with an improved patch. Reposit

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

jfb added a comment. In D74361#1879559 , @rjmccall wrote: > I'm not sure if it's a good idea to be re-using the existing attribute like > this. It's not that unreasonable, I guess, but I'd like to hear JF's > thoughts. The current uninitialized attrib

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

rjmccall added a comment. I'm not sure if it's a good idea to be re-using the existing attribute like this. It's not that unreasonable, I guess, but I'd like to hear JF's thoughts. I think you do need to update the documentation to mention the impact on globals. For normal targets (i.e. ones

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

jdoerfert added a comment. FWIW, this would really help us to create an OpenMP device (=GPU) runtime written almost entirely in OpenMP, C++, and very few clang builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

JonChesterfield created this revision. JonChesterfield added reviewers: kcc, rjmccall, rsmith, glider, vitalybuka, pcc, eugenis, vlad.tsyrklevich, jdoerfert, gregrodgers. Herald added a project: clang. Herald added a subscriber: cfe-commits. [Clang] Uninitialize attribute on global variables Ext