[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

2020-02-07 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") JDevlieghere wrote: > kschwarz wrote: > > Hi @JDevlieghere,

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

2020-02-07 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") kschwarz wrote: > Hi @JDevlieghere, we've noticed that with

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

2020-02-07 Thread Konstantin Schwarz via Phabricator via cfe-commits
kschwarz added inline comments. Comment at: llvm/test/CMakeLists.txt:171 +if(LLVM_BUILD_TOOLS) + set(exclude_from_check_all "EXCLUDE_FROM_CHECK_ALL") Hi @JDevlieghere, we've noticed that with this patch check-llvm isn't added to check-all anymore by default.

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

2020-02-06 Thread Jonas Devlieghere via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4fe839ef3a51: [CMake] Rename EXCLUDE_FROM_ALL and make it an argument to add_lit_testsuite (authored by JDevlieghere). Herald added projects: clang, Sanitizers, OpenMP. Herald added subscribers: openmp-com