[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc marked 5 inline comments as done. pcc added inline comments. Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:87 + bl __hwasan_check_x0_2_short // call outlined tag check +// (a

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. pcc marked an inline comment as done. Closed by commit rG7931e8eee3da: Update hwasan docs to cover outlined checks and globals. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D74150?vs=242962&id=2430

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Kostya Serebryany via Phabricator via cfe-commits
kcc accepted this revision. kcc added a comment. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74150/new/ https://reviews.llvm.org/D74150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added inline comments. Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:73 +and performance overhead of the call is reduced by using a custom calling +convention that preserves most registers and is specialized to the register +containing the address and th

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:87 + bl __hwasan_check_x0_2_short // call outlined tag check +

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

2020-02-06 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc created this revision. pcc added reviewers: eugenis, hctim, kcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74150 Files: clang/docs/HardwareAssistedAddressSanitizerDesign.rst Index: clang/docs/Hard