[PATCH] D73942: [hip] Properly populate macros based on host processor.

This revision was automatically updated to reflect the committed changes. Closed by commit rGccac6b2bf877: [hip] Properly populate macros based on host processor. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73942/new/ https://

[PATCH] D73942: [hip] Properly populate macros based on host processor.

hliao updated this revision to Diff 242400. hliao added a comment. `s/--hip-use-aux-triple-only/--gpu-use-aux-triple-only/g` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73942/new/ https://reviews.llvm.org/D73942 Files: clang/include/clang/Driv

[PATCH] D73942: [hip] Properly populate macros based on host processor.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you for adding the escape hatch option. Comment at: clang/include/clang/Driver/Options.td:552 +def hip_use_aux_triple_only : Flag<["--"], "hip-use-aux-triple-only">, + Int

[PATCH] D73942: [hip] Properly populate macros based on host processor.

hliao updated this revision to Diff 242395. hliao added a comment. Follow the reviewer's comment and an internal option `--hip-use-aux-triple-only` to fall back the original behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73942/new/ https:/

[PATCH] D73942: [hip] Properly populate macros based on host processor.

hliao added a comment. In D73942#1857384 , @tra wrote: > On one hand the change makes sense to me and fits well with what we've done > so far. > On the other hand, I worry that this is likely to break things. > We sort of have been implicitly relying on

[PATCH] D73942: [hip] Properly populate macros based on host processor.

tra added a comment. On one hand the change makes sense to me and fits well with what we've done so far. On the other hand, I worry that this is likely to break things. We sort of have been implicitly relying on not having the macros related to advanced CPU features enabled on device side which

[PATCH] D73942: [hip] Properly populate macros based on host processor.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - The device compilation needs to have a consistent source code compared to the corresponding host compilation. If macros based on the host-specific target proc