This revision was automatically updated to reflect the committed changes.
Closed by commit rGf5086b3803ac: [analyzer] StdLibraryFunctionsChecker
refactor: remove macros (authored by martong).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73897/new/
martong added a comment.
Thanks for the review guys!
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:537-551
+ // The format is as follows:
//{ "function name",
- // { spec:
+ // { variant0:
//{ argument types list, ... },
- //r
martong updated this revision to Diff 243552.
martong marked 7 inline comments as done.
martong added a comment.
- Ditch comment about (macro) format
- Use {} with RetType
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73897/new/
https://reviews.llv
NoQ accepted this revision.
NoQ added a comment.
LGTM, thanks again!
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:537-551
+ // The format is as follows:
//{ "function name",
- // { spec:
+ // { variant0:
//{ argument types list, .
martong marked 2 inline comments as done.
martong added a comment.
Herald added a subscriber: steakhal.
Ping @NoQ
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:42-49
// The following standard C functions are currently supported:
//
// fgetc
Szelethus added inline comments.
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:42-49
// The following standard C functions are currently supported:
//
// fgetc getline isdigit isupper
// fread isalnum isgraph isxdigit
//
martong added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:33
//
// This checker uses eval::Call for modeling "pure" functions, for which
// their `FunctionSummaryTy' is a precise model. This avoids unnecessary
martong updated this revision to Diff 243167.
martong marked 6 inline comments as done.
martong added a comment.
- Describe what pure means
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73897/new/
https://reviews.llvm.org/D73897
Files:
clang/lib
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
This is amazing. LGTM, granted that @NoQ is happy with the patch as well.
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:33
//
// This c
martong updated this revision to Diff 243117.
martong marked an inline comment as done.
martong added a comment.
- Rename several types
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73897/new/
https://reviews.llvm.org/D73897
Files:
clang/lib/Sta
martong marked 3 inline comments as done.
martong added inline comments.
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:537-551
+ // The format is as follows:
//{ "function name",
- // { spec:
+ // { variant0:
//{ argument types list,
NoQ added a comment.
This looks fantastic, i didn't think of this originally. All hail type safety!
Nits below.
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:182
+
+FunctionSummaryTy &Specification(ValueRangeSet VRS) {
+ Ranges.push_back(
merge_guards_bot added a comment.
{icon times-circle color=red} Unit tests: fail. 62099 tests passed, 5 failed
and 784 were skipped.
failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp
failed:
martong created this revision.
martong added a reviewer: NoQ.
Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy,
Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware,
xazax.hun, whisperity.
Herald added a project: clang.
Repository:
rG LLVM G
14 matches
Mail list logo
