[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c8c9905c249: make sure to not warn about unused macros from -D (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://revie

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

llunak added a comment. In D73846#1991330 , @rsmith wrote: > Looks OK as a workaround. Do you know why we consider these to be in the main > file? If we could fix that in the source manager, that'd seem preferable. According to my testing, SourceManager

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks OK as a workaround. Do you know why we consider these to be in the main file? If we could fix that in the source manager, that'd seem preferable. CHANGES SINCE LAST ACTION https://rev

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

llunak added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

dblaikie added a comment. Looks pretty reasonable to me - but I don't know enough about the macro and source location infrastructure. @rsmith - mind taking a quick look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846