modocache added inline comments.
Comment at: llvm/include/llvm/IR/IRBuilder.h:137
+
+ Value *Insert(Value *V, const Twine& = "") const {
+if (Instruction *I = dyn_cast(V))
I experienced a tiny regression after applying this patch, and I think this
line migh
teemperor added a comment.
This broke the LLVM_ENABLE_MODULES build because it introduces a cyclic
dependency between LLVM_IR and LLVM_intrinsic_gen:
FAILED:
tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o
/Applications/Xcode.app/Contents/De
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3eaa53e80543: Reapply "[IRBuilder] Virtualize
IRBuilder" (authored by nikic).
Changed prior to commit:
https://reviews.llvm.org/D73835?vs=244871&id=245004#toc
Repository:
rG LLVM Github Monorepo
CHA
xbolva00 added a comment.
@nikic: Can you please do compile-time benchmarks w/o this patch with e.g. php ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73835/new/
https://reviews.llvm.org/D73835
___
c
nikic added a comment.
Tried what happens if the copy constructor is deleted:
https://gist.github.com/nikic/1e6ab5bbf42cfe48e7b848e60a2df180 It looks like
the referenced occurrence in DIBuilder was the only place that was using the
copy constructor "for good reason", most of the other uses eith
nikic reopened this revision.
nikic added a comment.
This revision is now accepted and ready to land.
Reverted because of failures on
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/22164.
Not sure why this is the only builder that's failing, but I believe the
pr
thakis added a comment.
This causes this build warning:
../../llvm/include/llvm/IR/IRBuilder.h:77:16: warning: 'anchor' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
virtual void anchor();
^
../../llvm/include/llvm/IR/IRBuilde
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0765d3824d06: [IRBuilder] Virtualize IRBuilder (authored by
nikic).
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
