[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8865c01944f: [clangd] Pull out a isProtoFile function. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 242543. hokein added a comment. address a final comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-e

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/SourceCode.cpp:1139 + // Double check that this is an actual protobuf header. + if (!SM.getBufferData(FID).startswith

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 242536. hokein added a comment. update based on the offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet added a comment. In D73780#1851920 , @hokein wrote: > In D73780#1851654 , @kadircet wrote: > > > LG. I might be missing some context though, what's the reasoning behind? > > Because, I think it is not nece

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62288 tests passed, 8 failed and 837 were skipped. failed: LLVM.CodeGen/AMDGPU/branch-relaxation.ll failed: LLVM.CodeGen/AMDGPU/cf-loop-on-constant.ll failed: LLVM.CodeGen/AMDGPU/infinite-loop.ll failed: LL

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62288 tests passed, 8 failed and 837 were skipped. failed: LLVM.CodeGen/AMDGPU/branch-relaxation.ll failed: LLVM.CodeGen/AMDGPU/cf-loop-on-constant.ll failed: LLVM.CodeGen/AMDGPU/infinite-loop.ll failed: LL

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 241735. hokein added a comment. add trailing blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ex

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 241734. hokein marked 3 inline comments as done. hokein added a comment. update, and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-too

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein added a comment. In D73780#1851654 , @kadircet wrote: > LG. I might be missing some context though, what's the reasoning behind? > Because, I think it is not necessary to treat protobufs differently. > > It might be sensible to have a more generic

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62288 tests passed, 8 failed and 837 were skipped. failed: LLVM.CodeGen/AMDGPU/branch-relaxation.ll failed: LLVM.CodeGen/AMDGPU/cf-loop-on-constant.ll failed: LLVM.CodeGen/AMDGPU/infinite-loop.ll failed: LL

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet added a comment. LG. I might be missing some context though, what's the reasoning behind? Because, I think it is not necessary to treat protobufs differently. It might be sensible to have a more generic `isSymbolFromGeneratedFile` filter, but also for this one I don't see any developme

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/CMakeLi