[PATCH] D7375: [clang-tidy] Assert related checkers

2017-12-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Herald added a subscriber: mgorny. Comment at: test/clang-tidy/misc-static-assert.cpp:71 + + assert(ZERO_MACRO && "Report me!"); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() that could be Hmm. Are you sure about

[PATCH] D7375: [clang-tidy] Assert related checkers

2017-03-24 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: test/clang-tidy/misc-assert-side-effect.cpp:67 + + assert(freeFunction()); + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() with side effect Is it intentional that the check also warns on free functions