[PATCH] D73701: [clang] fix linkage of nested lambda

hliao added a comment. In D73701#1864136 , @blastrock wrote: > Thanks for the reviews! I do not have commit access, so please merge this > whenever you can. done in 2926917f430 . than

[PATCH] D73701: [clang] fix linkage of nested lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rG2926917f430d: [clang] Fix linkage of nested lambdas. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D73701?vs=241713&id=243224#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D73701: [clang] fix linkage of nested lambda

blastrock added a comment. Thanks for the reviews! I do not have commit access, so please merge this whenever you can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73701/new/ https://reviews.llvm.org/D73701

[PATCH] D73701: [clang] fix linkage of nested lambda

hliao accepted this revision. hliao added a comment. This revision is now accepted and ready to land. LGTM, but need @rsmith for the final review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73701/new/ https://reviews.llvm.org/D73701 __

[PATCH] D73701: [clang] fix linkage of nested lambda

blastrock updated this revision to Diff 241713. blastrock edited the summary of this revision. blastrock added a reverted change: D1783: Allow nested lambdas in NSDMIs (i.e default initializers). blastrock added a comment. Thank you for the answers. I have removed all the outermost lambda code a

[PATCH] D73701: [clang] fix linkage of nested lambda

rsmith added a comment. This is effectively reverting https://reviews.llvm.org/D1783. If we don't need that any more for whatever reason, can we also get rid of the check for whether the outermost lambda has a mangling number a few lines above? (Please also check if we can remove `getOutermostE

[PATCH] D73701: [clang] fix linkage of nested lambda

hliao added a comment. + rsmith Comment at: clang/lib/AST/Decl.cpp:1416-1417 return getLVForClosure( - OuterMostLambda->getDeclContext()->getRedeclContext(), - OuterMostLambda->getLambdaContextDecl(), computation); + R

[PATCH] D73701: [clang] fix linkage of nested lambda

blastrock created this revision. blastrock added reviewers: rjmccall, hliao. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is an attempt to fix https://bugs.llvm.org/show_bug.cgi?id=44368 I don't know why the comment said that we should take the linkage of the outer